Remove required check of version field for CRAN and Swift#87
Open
calebbrown wants to merge 1 commit intopackage-url:masterfrom
Open
Remove required check of version field for CRAN and Swift#87calebbrown wants to merge 1 commit intopackage-url:masterfrom
calebbrown wants to merge 1 commit intopackage-url:masterfrom
Conversation
Signed-off-by: Caleb Brown <calebbrown@google.com>
Collaborator
|
Thanks for the PR. I'd like to incorporate both of these cases in #83, which adapts to code to pass the upstream (purl-spec) defined tests.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the version for the Swift and CRAN ecosystems is validated as "required". If the version is missing for these ecosystems then validation fails.
According to https://github.com/package-url/purl-spec/blob/main/types/cran-definition.json and https://github.com/package-url/purl-spec/blob/main/types/swift-definition.json the "version" field is optional.
This change removes this check for these ecosystems.